-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh: pandas-like semi join #439
Conversation
CI failure is unrelated π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yessssss love semi-joins, amazing stuff @FBruzzesi !
Minor comment - hopefully CI is more robust after #456
tests/frame/test_common.py
Outdated
(["a", "b"], (nw.col("b") < 5), {"a": [1, 3], "b": [4, 4], "z": [7, 8]}), | ||
], | ||
) | ||
def test_semi_join( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as this is a new test, could we use the constructor
fixture for this one, and maybe create a new tests/frame/join_test
file that we can later migrate the join tests to?
@MarcoGorelli we have another random attacker! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below.
Disclaimer: I think I never used a semi join before. From the polars docs this seems like it should do the trick π